-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transitive dependency to work towards removing syn <1.0 dep #71919
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Were you intending to land this and then follow up once those upstream PRs are merged and released, or do you want to wait here? If you're happy to merge now then I'm fine with that, r=me |
I'm fine either way but since this prunes 2 dependencies already (hashbrown 0.5.0 and synstructure 0.12.1), let's land this now and I'll follow up when the upstream fixes are released. Thanks for taking a look! @bors r=Mark-Simulacrum |
📌 Commit 371ddd7 has been approved by |
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
This PR failed in #72073 (comment) (re-rollup without this worked). Likely the lockfile needs updating. @bors r- |
📌 Commit e26f35d has been approved by |
⌛ Testing commit e26f35d with merge fbdc1a61e7aeb2779fe99f65841955f4c3ffc875... |
💔 Test failed - checks-azure |
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
@bors p=1 |
⌛ Testing commit e26f35d with merge c4d9e53e27488374be218e4b96302b10acb2b5c2... |
@bors retry yield |
⌛ Testing commit e26f35d with merge 8fd1450a80cb804c450c1ba53dba0b18eb6a71f8... |
@bors retry yield |
⌛ Testing commit e26f35d with merge 70e1c77063eac6ece06b9b578733c055e118cd0c... |
💔 Test failed - checks-azure |
@bors r+ rollup |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit e26f35d has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#71625 (Improve the documentation for ManuallyDrop to resolve conflicting usage of terminology) - rust-lang#71919 (Update transitive dependency to work towards removing syn <1.0 dep) - rust-lang#72166 (Simpler slice `Iterator` methods) - rust-lang#72216 (Remove `lang_items\(\).*\.unwrap\(\)`) - rust-lang#72230 (Updated documentation of Prefix::VerbatimDisk) - rust-lang#72234 (Implement Default for proc_macro::TokenStream) - rust-lang#72258 (Fix typo Arbintrary to Arbitrary) Failed merges: r? @ghost
Update transitive dependencies to remove some deps Similar to rust-lang#71919, this removes some (duplicate) dependencies.
This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210.
While working on #71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.